-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Open
Description
I'm opening this issue to track it properly. In short:
- Open https://github.com/refined-github/refined-github/blob/main/source/features/action-used-by-link.tsx
- Visit a folder or change file via the sidebar or go back and forth
Known issues
turbo:renderisn't calledpopstateevents don't trigger anyturbo:rendernorsoft-nav:render- the view isn't generated from scratch, so previous elements stick around
Related issues
download-folder-buttonduplicated #6414rgh-feature-descriptionsonly works when opened in a new page #6528- All the linked issues in the conversation below
Current status
For the whole existence of Refined GitHub, we've relied on GitHub to delete our elements when the page/URL changes, with one exception (I don't remember which). New React-based views break this assumption. I think we need to:
- listen to
soft-nav:render - listen to
popstateand avoid duplicates calls in casesoft-nav:renderis also fired - figure out a way to make widgets/buttons dynamic so that they change or disappear when the URL changes
- this could help, but that alone doesn't fit into our concept of "feature unloading when pages change": A brief investigation of using SolidJS #6493
- maybe we could add a
onAbort(() => element.remove())- edit: I tried it, but if an
rgh-seenelement is still on the page, it won't be seen again.
- edit: I tried it, but if an
134130, EnixCoda, bb010g and Mubelotixkarlhorkykarlhorky