LogMonitor now attempts to call .toJS() on state entries.#70
Closed
dvdzkwsk wants to merge 1 commit intoreduxjs:masterfrom
dvdzkwsk:fix-immutable-js
Closed
LogMonitor now attempts to call .toJS() on state entries.#70dvdzkwsk wants to merge 1 commit intoreduxjs:masterfrom dvdzkwsk:fix-immutable-js
dvdzkwsk wants to merge 1 commit intoreduxjs:masterfrom
dvdzkwsk:fix-immutable-js
Conversation
Author
|
Aaaaand just saw #66 so this might not be the desired solution. I'll read through that again and see if I can rework the implementation. |
Contributor
|
It's best if we can support anything iterable, not just Immutable. |
Author
|
Right, totally makes sense. I'll try to update the PR later when I get home. |
Contributor
|
Closing in favor of #79. |
Contributor
|
Should be fixed in 1.1.0, please verify. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix the unreadable state entries for ImmutableJS. I really didn't want to do the manipulation in the render method, but from what I saw in terms of how states are computed and stored I couldn't think of a better solution that didn't significantly alter that part of the codebase.
Anyways, feedback is appreciated. Maybe somebody has a better solution in mind, but this seems to be working for me.