Conversation
|
Let me know if/when you have a cohesive plan, would love to jump in and help out! |
|
@mxstbr I’d appreciate if you could update some of the other examples to the same build setup/convention I made in |
|
Updated the counter example in f7b5220 for a start! (everything works perfectly fine, inc. HMR and building) I'd appreciate a sanity check that everything is correctly before I go ahead and update some other ones. Are there specific ones (like the universal one maybe?) that shouldn't be touched? |
|
Looks like #1883 supercedes this work. Or at least the majority of the infrastructure changes. Let's close this for now, work through the create-react-app changes, and then do a new PR with any further updates after the dust settles with the tooling. |
|
Yea. The funny thing is that not wanting to come back to this PR was one of the driving forces behind Create React App. 😄 |
Just letting everyone I decided to start working on updating all examples.
I’m starting with work @xulien did in #1403 and adding stuff on top.
There is no cohesive plan yet, but I want to:
I have no idea how long it’s going to take (I’ll work on this in my free time). I’ll likely try to cherry-pick some tests in the open PRs, and use them here.