Skip to content

Fix tooltips on beta badge #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JakeSCahill merged 2 commits into from
Dec 1, 2025
Merged

Fix tooltips on beta badge #349

JakeSCahill merged 2 commits into from
Dec 1, 2025

Conversation

@JakeSCahill
Copy link
Contributor

@JakeSCahill JakeSCahill commented Nov 26, 2025 •
edited
Loading

Tooltips were being cut off by nav nav tree on desktop. This PR attaches them to the body element to prevent this.

  • Added the appendTo: () => document.body option to the tooltip initialization for both betaBadge and navBadge elements, improving tooltip rendering reliability. [1] [2]

@netlify
Copy link

netlify bot commented Nov 26, 2025 •
edited
Loading

✅ Deploy Preview for docs-ui ready!

Name Link
🔨 Latest commit aa88e96
🔍 Latest deploy log https://app.netlify.com/projects/docs-ui/deploys/6926dda587abba0008239392
😎 Deploy Preview https://deploy-preview-349--docs-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 30 (🟢 up 1 from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 89 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 26, 2025 •
edited
Loading

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

This pull request adds appendTo: () => document.body to two tippy tooltip initializations (topBadge and navBadge) in the article.hbs partial template. This configuration forces tooltips to render appended to the document body rather than using their default positioning behavior. No other functional changes are made.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Single file modified with repetitive, homogeneous configuration changes
  • Verify that forcing tooltips to the document body does not introduce z-index, styling, or positioning issues in the document structure
  • Confirm this change aligns with any existing tooltip positioning patterns in the codebase

Possibly related PRs

  • Add styles for inline badges #304: Modified tooltip initializations in the same file (src/partials/article.hbs), specifically updating tooltip content to use page.attributes.beta-text, indicating active work on tooltip behavior in this component.

Suggested reviewers

  • kbatuigas

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change - fixing tooltips on the beta badge by appending them to the document body.
Description check ✅ Passed The description clearly explains the problem (tooltips cut off by nav tree) and the solution (appending to body element), directly relating to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@JakeSCahill JakeSCahill requested review from a team and paulohtb6 November 26, 2025 13:40
@JakeSCahill JakeSCahill merged commit 58496f8 into main Dec 1, 2025
6 checks passed
@JakeSCahill JakeSCahill deleted the fix-tooltips branch December 1, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulohtb6 paulohtb6 paulohtb6 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JakeSCahill @paulohtb6