Skip to content

Exclude home role #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JakeSCahill merged 1 commit into from
Nov 11, 2025
Merged

Exclude home role #343

JakeSCahill merged 1 commit into from
Nov 11, 2025

Conversation

@JakeSCahill
Copy link
Contributor

@JakeSCahill JakeSCahill commented Nov 11, 2025 •
edited
Loading

Stops the page options from being displayed on the home page.

@netlify
Copy link

netlify bot commented Nov 11, 2025 •
edited
Loading

✅ Deploy Preview for docs-ui ready!

Name Link
🔨 Latest commit 223710e
🔍 Latest deploy log https://app.netlify.com/projects/docs-ui/deploys/69136c6e9dff6600081d4a12
😎 Deploy Preview https://deploy-preview-343--docs-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 27 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 88 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 11, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The change modifies src/helpers/has-markdown.js by adding a single role ('home') to an existing exclusion list. The list of roles that cause pages to be treated as non-markdown expands from ['bloblang-playground', 'component-home-v2'] to include 'home' as an additional exclusion. No other logic, control flow, or public API surfaces are affected.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single-line addition to an array with no logic changes or side effects
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch patch-fix
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 855bd63 and 223710e.

📒 Files selected for processing (1)
  • src/helpers/has-markdown.js (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@JakeSCahill JakeSCahill merged commit 9847a6c into main Nov 11, 2025
5 of 6 checks passed
@JakeSCahill JakeSCahill deleted the patch-fix branch November 11, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Feediver1 Feediver1 Feediver1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JakeSCahill @Feediver1