Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

Documents consumer group lag#1694

Merged
oranagra merged 6 commits into
redis:masterfrom
itamarhaber:stream-cglag
Feb 27, 2022
Merged

Documents consumer group lag#1694
oranagra merged 6 commits into
redis:masterfrom
itamarhaber:stream-cglag

Conversation

@itamarhaber

@itamarhaber itamarhaber commented Nov 28, 2021

Copy link
Copy Markdown
Member

Upstream ref: redis/redis#9127
update commands .json from unstable (pre 7.0 RC2)

@itamarhaber itamarhaber added the waiting-for-upstream waiting for a redis PR to be merged label Nov 29, 2021

@zuiderkwast zuiderkwast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I didn't proof read the examples, assuming they're generated.

Do we need to wait for and/or coordinate with redis/redis#9656 regarding commands.json?

Comment thread wordlist Outdated
Comment thread commands/xinfo-groups.md Outdated
Comment thread commands/xinfo-groups.md Outdated
@oranagra oranagra added to-be-merged should probably be merged soon and removed waiting-for-upstream waiting for a redis PR to be merged labels Feb 23, 2022
@oranagra

Copy link
Copy Markdown
Member

@itamarhaber what the hell happened to commands.json in this PR?

@oranagra

Copy link
Copy Markdown
Member

ohh, this PR is based on a very old version of the master branch.
but you've re-genrated the commands.json, so it looks like it completely changes it.
i'll merge the master into this one and re-generate commands.json again.

@oranagra oranagra merged commit 51deb07 into redis:master Feb 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

to-be-merged should probably be merged soon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants