Add new LMPOP and BLMPOP commands. #1636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oranagra
reviewed
Aug 30, 2021
Member
oranagra
left a comment
There was a problem hiding this comment.
@yoav-steinberg please take it from here..
Co-authored-by: Oran Agra <oran@redislabs.com>
Co-authored-by: Oran Agra <oran@redislabs.com>
Co-authored-by: Oran Agra <oran@redislabs.com>
Co-authored-by: Oran Agra <oran@redislabs.com>
Co-authored-by: Oran Agra <oran@redislabs.com>
yoav-steinberg
suggested changes
Aug 31, 2021
Contributor
yoav-steinberg
left a comment
There was a problem hiding this comment.
Added some suggestions.
Also need to add deprecation notices for B[RL]POP and [RL]POP commands.
(assuming we're really deprecating them). If not please let me know and I'll fix my suggestions accordingly.
See question here: redis/redis#9373 (comment)
yoav-steinberg
suggested changes
Aug 31, 2021
Co-authored-by: yoav-steinberg <yoav@monfort.co.il>
Co-authored-by: yoav-steinberg <yoav@monfort.co.il>
Co-authored-by: yoav-steinberg <yoav@monfort.co.il>
yoav-steinberg
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: haven't tried local rendering, not sure about the output render.
I am also not very good at long sentences, not sure I have covered everything.