docs for new MINID trim strategy#1488
Conversation
oranagra
left a comment
There was a problem hiding this comment.
sorry for hogging this PR to discuss the new style guides and evaluate their pros and cons.
commands.json
Outdated
| "name": "threshold", | ||
| "type": "string" |
There was a problem hiding this comment.
maybe instead of
XTRIM key (MAXLEN|MINID) [=|~] threshold
we want:
XTRIM key ([MAXLEN [=|~] length] | [MINID [=|~] id])
i.e. this way we can name the length as such, and keep it an integer.
There was a problem hiding this comment.
Regrettably, our syntax has implied parenthesis and no way to explicitly state that. Yet another point for future improvement.
There was a problem hiding this comment.
@itamarhaber why can't we do this:
XTRIM key [MAXLEN [=|~] length] | [MINID [=|~] id]
and then state somewhere that you must provide at least, and only one.
i'm not certain it's better than
XTRIM key (MAXLEN|MINID) [=|~] threshold
just suggesting
commands/xtrim.md
Outdated
| This option is only valid with the `~` modifier and its default is (100 * the number | ||
| of entries per macro node). |
There was a problem hiding this comment.
referring to "macro node" maybe we wanna refer to stream-node-max-entries?
|
Syntax preview:
|
No description provided.