-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Generate RDB with Functions only via redis-cli --functions-rdb #9968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oranagra
reviewed
Dec 20, 2021
oranagra
reviewed
Dec 21, 2021
This avoids overwriting the snapshot RDBs with filtered data.
oranagra
reviewed
Dec 27, 2021
Member
|
@redis/core-team please approve (see details in the top comment) |
sundb
reviewed
Dec 29, 2021
sundb
reviewed
Dec 29, 2021
Co-authored-by: sundb <sundbcn@gmail.com>
oranagra
reviewed
Dec 29, 2021
oranagra
reviewed
Dec 30, 2021
yossigo
approved these changes
Dec 30, 2021
Collaborator
yossigo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (but did not do a complete code review).
oranagra
approved these changes
Dec 31, 2021
itamarhaber
approved these changes
Dec 31, 2021
… use static info_updated_time
oranagra
approved these changes
Dec 31, 2021
sundb
reviewed
Dec 31, 2021
Co-authored-by: sundb <sundbcn@gmail.com>
sundb
reviewed
Jan 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approval-needed
Waiting for core team approval to be merged
release-notes
indication that this issue needs to be mentioned in the release notes
state:major-decision
Requires core team consensus
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed in order to ease the deployment of functions for ephemeral cases, where user needs to spin up a server with functions pre-loaded.
See #9899 (comment) and following comments.
Details:
--functions-rdboption to redis-cli.REPLCONF rdb-filter-only functions. This is a placeholder for a space separated inclusion filter for the RDB. In the future can beREPLCONF rdb-filter-only "functions db:3 key-patten:user*"and a complementingrdb-filter-excludeREPLCONFcan also be added.int, but can be extended to a more complex structure with various filter fields.other changes:
TODO: