Make BITFIELD_RO reject OVERFLOW subcommand #9930
Conversation
GET subcommand reject OVERFLOW subcommand.
|
Added. |
oranagra
left a comment
There was a problem hiding this comment.
@redis/core-team please approve or share your thoughts.
note that this is a breaking-change, since an argument that used to be ignored will now error.
yossigo
left a comment
There was a problem hiding this comment.
LGTM, I'm not sure such a breaking change is generally justified but as this command was only introduced in 6.2 it makes more sense.
|
@yossigo the BITFIELD_RO was introduced in 6.2, but this PR also affects plain BITFIELD. the real exception is obviously when security is a concern (Like silently skipping an ACL arg, which can lead to user thinking something was done when it wasn't). bottom line, if we wanna "fix" this, 7.0 is our chance. but since this is harmless, i'm ok with not fixing this. |
|
@oranagra If everyone agrees the original problem is indeed harmless, I lean towards not breaking anything to fix it. |
|
that's what i'm leaning towards. let's seek a 3rd person opinion before closing. |
|
I would generally vote to not break backwards compatibility, this doesn't seem like a very important change. |
|
great. so we all agree it's a good fix, but also that it doesn't worth breaking compatibility. |
make BITFIELD with only GET subcommand reject OVERFLOW subcommand.