Skip to content

attempt to fix tracking test issue with external tests due to lazy free #9722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oranagra merged 1 commit into from
Nov 2, 2021
Merged

attempt to fix tracking test issue with external tests due to lazy free #9722

oranagra merged 1 commit into from
Nov 2, 2021

Conversation

@oranagra
Copy link
Member

@oranagra oranagra commented Nov 2, 2021 •
edited
Loading

external tests started failing recently for unclear reason:

*** [err]: Tracking invalidation message of eviction keys should be before response in tests/unit/tracking.tcl
Expected '0' to be equal to 'invalidate volatile-key' (context: type eval line 21 cmd {assert_equal $res {invalidate volatile-key}} proc ::test)

I suspect the issue is that the used_memory sample is taken while a lazy free is still being processed.
see discussion in #9422

@oranagra oranagra mentioned this pull request Nov 2, 2021
Merged
@oranagra oranagra requested a review from yossigo November 2, 2021 13:39
@oranagra oranagra merged commit 87321de into redis:unstable Nov 2, 2021
@oranagra oranagra deleted the fix_tracking_external branch November 2, 2021 14:42
@oranagra oranagra mentioned this pull request Nov 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yossigo yossigo yossigo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oranagra @yossigo