Fixes CLUSTER COUNTKEYSINSLOT
#9672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madolson
approved these changes
Oct 23, 2021
Contributor
madolson
left a comment
There was a problem hiding this comment.
Maybe we should figure out a sanity test to make sure we have 100% of commands covered.
Member
we can write some code in introspection.tcl that tries to call all commands and sub-commands by parsing the output of COMMAND command, but that would be hard / silly since many commands would fail, and even the ones that succeeds, we won't verify their output. the better way is to periodically generate coverage report and try to increase coverage.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced via typo in #9504. Reported by @sazzad16.
Also adds a sanity test for coverage.
Additional seemingly uncovered
CLUSTERsubcommands:BUMPEPOCH,COUNT-FAILURE-REPORTS,FORGET,FLUSHSLOTS,KEYSLOT,SAVECONFIG