using dns address for the configuration of "sentinel announce-ip" , "replica-announce-ip" and "replicaof"#7758
Closed
myl1024 wants to merge 2 commits into
Closed
using dns address for the configuration of "sentinel announce-ip" , "replica-announce-ip" and "replicaof"#7758myl1024 wants to merge 2 commits into
myl1024 wants to merge 2 commits into
Conversation
…ntinel (ie, sentinel announce-ip sentinel-0-svc) or redis (ie, replica-announce-ip redis-0-svc & replicaof redis-0-svc)
- Add sentinelAddrEqualsHostname() to simplify comparision of hostname with a sentinelAddr. - Some parameter name updates to reflect that we're now expecting hostnames and IPs and not just IPs. - Fix logic of getSentinelRedisInstanceByAddrAndRunID() which failed the tests.
Collaborator
|
Thanks @myl1024, I've reviewed your work and pushed another commit to suggest a few cleanups and fix the Sentinel failing tests. My comments are in the commit, please let me know if this makes sense and works for you. |
Collaborator
|
Related to #2118, and we'll need to consider the issue of timing discussed in the original ticket before progressing with this. |
Contributor
Author
|
@yossigo Thanks for your review. Your commit is more concise and robust. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we deploy redis in kubernetes, each pod corresponds to a redis instance or sentinel instance, using the dns address as the pod's fixed external address, we found:
So, in these scenarios,
This PR is related to #7393