add force option to 'create-cluster create' script call #7599
Conversation
|
@meierfra-ergon we don't take PRs directly into the release branch. IIUC your previous PR had the same intention as time one, but used environment variable instead. so considering some users already use the environment variable, do you think we better keep the previous approach? or is there a problem with it and you prefer the one in this PR? |
|
@oranagra thanks, I think you're right I should implement the same behavior (with the environment variable) to not break compatibility in redis-cli. |
|
@meierfra-ergon i'm ok with having both options. the previous one was already accepted by Salvatore and merged, and i suppose we better keep backwards compatibility (of redis-cli, not just the create-cluster script). and the new one is more convenient to use, and it doesn't add any significant code complexity. |
This is a followup on my PR #5879 for Redis 6.0.
With Redis 6.0 redis-cli has an option to force cluster creation (without interaction) via the '--cluster-yes' option. Unfortunately there is still no '--force' option for the 'create-cluster create' script command.
Therefore I created this pull request to add a simple '-f' option to the script command. A more versatile approach would be to generically pass-thorough command-line options to redis-cli, but I wanted to keep the pull request small (to begin with).