Improve lazyfree eviction #4544
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @antirez
There are three problems about lazyfree eviction I think:
We forgot the latency generated by waiting for
BIO_LAZY_FREEI think it's necessary to record this kind of latency.
Maybe we misuse
latencyRemoveNestedEventIn my opinion the
eviction-cycleshould contains all latency, includingeviction-delandeviction-lazyfree, so we should not removeeviction-delfromeviction-cycle.The last problem is about
cant_freeWhen we goto
cant_free, we wait forBIO_LAZY_FREEfinished or break if already freed enough memory.But, we use
mem_freedduplicately.I add a variable
mem_used_initto record the initial used memory, please check.