Fix CONFIG SET for client-output-buffer-limit.#3465
Closed
malisper wants to merge 1 commit into
Closed
Conversation
b988c7e to
cfb0241
Compare
Previously any unit for hard/soft limit (e.g. GB) would be ignored. Additionally, you could include a unit for the time and Redis would not give a invalid argument error.
cfb0241 to
ecd5223
Compare
Contributor
|
Thanks, this is indeed a bug. It's been partially handled in 8c8e85d but not completely. Can you rebase and fix? |
Contributor
|
I changed a version of mine. Also handle |
Contributor
@enjoy-binbin I like this. Since we got no response from the original author of this PR I suggest you create a new PR and I'll close this one. |
Contributor
|
@yoav-steinberg Cool. I made a new one |
Contributor
|
Updated PR at #9308. closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously any unit for hard/soft limit (e.g. GB) would be
ignored. Additionally, you could include a unit for the time and Redis
would not give a invalid argument error.