Fix TSAN warning in hashTypeLength#15382
Merged
Merged
Conversation
TSan complains because server.allow_access_expired is accessed from a BIO thread: populateDeltaHistograms() reaches hashTypeLength via getObjectLength() with subtractExpiredFields==0. Fix it by reading that variable only when necessary, i.e. only when subtractExpiredFields is set.
Collaborator
|
This change touches performance-sensitive code paths. Adding the |
sundb
approved these changes
Jun 29, 2026
ShooterIT
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TSan complains because
server.allow_access_expiredis accessed from a BIO thread: populateDeltaHistograms() reaches hashTypeLength() via getObjectLength() with subtractExpiredFields==0.Fix it by reading that variable only when necessary, i.e. only when subtractExpiredFields is set.