Fix memory leak in trackingRememberKeys() for PUBSUB commands#14817
Merged
Conversation
🤖 Augment PR SummarySummary: Fixes a memory leak in key-tracking when handling PUBSUB commands by ensuring key-extraction results are always freed. Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
ShooterIT
reviewed
Feb 26, 2026
ShooterIT
approved these changes
Feb 26, 2026
sundb
approved these changes
Feb 26, 2026
This was referenced Mar 6, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When handling PUBSUB commands, the function was returning early without calling
getKeysFreeResult(), leading to a leak.Note
Low Risk
Low risk: small control-flow change limited to client-side caching key tracking; it primarily prevents a memory leak and should not affect non-PUBSUB tracking behavior.
Overview
Fixes a memory leak in
trackingRememberKeys()by returning early forCMD_PUBSUBcommands before callinggetKeysFromCommand(), avoiding an allocatedgetKeysResultthat previously wasn’t freed on the PUBSUB fast path.Written by Cursor Bugbot for commit 890ec87. This will update automatically on new commits. Configure here.