remove C++ std dependency#14812
Conversation
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
|
Daniel Lemire seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
|
@paulorsousa I think I fixed the issue with my latest commit.
Yes, I understand the issue. |
|
@lemire I can confirm it's compiling now |
|
@paulorsousa Thanks. Now, whether it is useful or not to you, I leave it up to you to judge. :-) |
|
I am going to close this and open a new PR. |
|
Close via #14661 |
The fast_float library does not depend on the C++ library so there is no point in linking against the C++ standard library. You only need a C++ compiler at compile time but no C++ library at runtime.
Alternative to #14661
(I hereby declare this work to be in the public domain. Merge it or not, I do not claim copyright over it.)
Note
Medium Risk
Changes global link flags in
src/Makefile, which can cause build/link failures on specific platforms or toolchains if any indirect C++ runtime dependency exists.Overview
Build now avoids a hard dependency on the C++ standard library.
FINAL_LIBSno longer includes-lstdc++by default, reducing runtime/link requirements when C++ is only used at compile time.On macOS, the Makefile explicitly links
-lc++alongside-ldlto satisfy the platform’s C++ runtime expectations without pulling inlibstdc++.Written by Cursor Bugbot for commit e640c98. This will update automatically on new commits. Configure here.