Change reply schema for hotkeys get to use map instead of flat array#14749
Merged
minchopaskal merged 2 commits intoredis:unstablefrom Jan 29, 2026
Merged
Conversation
🤖 Augment PR SummarySummary: This PR updates Changes:
Technical Notes: Conditional fields are included only when slot selection, sampling, or specific metric tracking (CPU/NET) is enabled. 🤖 Was this summary useful? React with 👍 or 👎 |
Collaborator
|
I wonder why the test doesn't fail. Last time we deleted all the "hello 3" |
Collaborator
Author
mhm. Good idea to add some resp3 tests back |
sundb
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow #14680
Reply of
HOTKEYS GETis an unordered collection of key-value pairs. It is more reasonable to be a map in resp3 instead of flat array.Note
Medium Risk
Changes the RESP3 wire response shape for
HOTKEYS GETfrom a flat array to a map, which can break client parsing expectations. Logic changes are localized but touch protocol reply formatting and length accounting.Overview
HOTKEYS GETnow replies as a RESP3 map (key/value pairs) rather than a flat array, by switching the deferred length finalization tosetDeferredMapLenand updating the internal length accounting to count map entries.The command spec (
hotkeys-get.json) is updated to describe an object/map reply with explicit properties, and unit tests add a RESP3-specific assertion (HELLO 3) that the outer reply is a dict/map while keeping the Top-K hotkey lists as flat arrays of alternating key/value elements.Written by Cursor Bugbot for commit df125e9. This will update automatically on new commits. Configure here.