Enforce 16-char hex digest length and case-insensitive comparison for IFDEQ/IFDNE#14502
Merged
sundb merged 4 commits intoredis:unstablefrom Nov 3, 2025
Merged
Enforce 16-char hex digest length and case-insensitive comparison for IFDEQ/IFDNE#14502sundb merged 4 commits intoredis:unstablefrom
sundb merged 4 commits intoredis:unstablefrom
Conversation
Co-authored-by: Marc Gravell <marc.gravell@gmail.com>
ShooterIT
approved these changes
Nov 3, 2025
…acters` Co-authored-by: Yuan Wang <yuan.wang@redis.com>
Collaborator
|
LGTM |
minchopaskal
approved these changes
Nov 3, 2025
Contributor
|
I have validated against the PR branch (ironically at the same time it was being merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #14496
This PR makes the following changes:
DIGEST: Always return 16 hex characters with leading zeros
Example: "00006c38adf31777" instead of "6c38adf31777"
IFDEQ/IFDNE: Validate the digest must be exactly 16 characters
IFDEQ/IFDNE: Use strcasecmp for case-insensitive hex comparison
Both uppercase and lowercase hex digits now work identically