Avoid allocation when iterating over hashes, lists, sets and kvstores #14473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
The version has been frozen. waiting for the release? |
6be9280 to
3de0686
Compare
3de0686 to
7c18666
Compare
7c18666 to
3f8a7e1
Compare
sundb
reviewed
Nov 20, 2025
sundb
approved these changes
Nov 21, 2025
This was referenced Dec 30, 2025
This was referenced Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is follow up on #14200 where we prefer storing iterators on the stack
rather than allocating on the heap. Here we continue this for iterators over
hashes, lists, sets and kvstores.
Quicklist's iterators are still using heap allocation and will be addressed
soon. The reason is that
NULLis perfectly valid quicklist iterator value andhandling this would be better reviewed separately from the mostly mechanical
changes here.