Use fixed position keys parameter for MSETEX command#14470
Merged
sundb merged 5 commits intoredis:unstablefrom Oct 27, 2025
Merged
Use fixed position keys parameter for MSETEX command#14470sundb merged 5 commits intoredis:unstablefrom
sundb merged 5 commits intoredis:unstablefrom
Conversation
Co-authored-by: Yuan Wang <yuan.wang@redis.com>
Co-authored-by: Yuan Wang <yuan.wang@redis.com>
ShooterIT
approved these changes
Oct 27, 2025
Collaborator
|
Why was this change necessary ? Only because of the added complexity in |
Member
|
proxy team said the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PR #14434, we made the keys parameter flexible, meaning it could appear anywhere among the command arguments. However, this also made key parsing more complex, since we could no longer determine the fixed position of key arguments. Therefore, in this PR, we reverted it back to using fixed positions for the keys.
And also fix this comment.