Merged
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
|
New Issues (6)Checkmarx found the following issues in this Pull Request
Fixed Issues (4)Great job! The following issues were fixed in this Pull Request
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses two flaky test cases that were causing unreliable test results. The first fix modifies the active defragmentation test to create hash keys instead of string keys for better fragmentation patterns. The second fix removes encoding verification checks that were sensitive to changes in Redis's internal encoding thresholds.
- Replaced string key creation with hash key creation in the memory efficiency defrag test to ensure consistent fragmentation behavior
- Removed object encoding verification checks from the protocol test to eliminate dependency on internal encoding size limits
- Updated comment references to match the modified test operations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/unit/protocol.tcl | Removes object encoding assertions that depend on internal encoding size limits |
| tests/unit/memefficiency.tcl | Changes test to use hash keys instead of string keys for more predictable defragmentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
oranagra
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mainly fixes two flakiness tests.
Fix the failure of
Active Defrag HFE with ebraxtest inmemefficiency.tclWhen
redisObjectstructure size changes, the current test design becomes flakiness:In the current test, we will create 1 hash key + N string keys. When we delete this string key, these hash keys may be evenly distributed in robj 's slabs, resulting in the inability to perform defragmentation.
Fix
bulk reply protocoltest inprotocol.tclintroduced by Fix index error of CRLF when replying with integer-encoded strings #13711When
OBJ_ENCODING_EMBSTR_SIZE_LIMIT(currently 44) changes, it can cause this test to fail. This isn't necessarily a problem, but the main issue is that we userawreadto verify encoding correctness. If the reply length doesn't match exactly, it can cause the test to hang and become difficult to debug.