Skip to content

Fix memleak issues in redis-cli#14186

Merged
ShooterIT merged 3 commits into
redis:unstablefrom
sfu2:fix-14184
Jul 11, 2025
Merged

Fix memleak issues in redis-cli#14186
ShooterIT merged 3 commits into
redis:unstablefrom
sfu2:fix-14184

Conversation

@sfu2

@sfu2 sfu2 commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

fix memleak in redis-cli. see issue #14184

@snyk-io

snyk-io Bot commented Jul 10, 2025

Copy link
Copy Markdown

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@shahsb shahsb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making the change!

@ShooterIT ShooterIT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, since this won't cause much damage, we don't need to back-port this commit to old version. cc @sundb

@ShooterIT ShooterIT changed the title fix memleak issue #14184 Fix memleak issue in redis-cli #14184 Jul 10, 2025
@ShooterIT ShooterIT linked an issue Jul 10, 2025 that may be closed by this pull request
@ShooterIT

Copy link
Copy Markdown
Member

since #14181 is similar to this one, could you merge these two into one?

@sfu2

sfu2 commented Jul 11, 2025

Copy link
Copy Markdown
Contributor Author

since #14181 is similar to this one, could you merge these two into one?

Sure, I've merged these two PRs. Now this PR should close these two issues: #14184 and #14180

@kaplanben

Copy link
Copy Markdown

Logo
Checkmarx One – Scan Summary & Detailseb6b13f4-3759-46e6-a77b-6bd2596624c7

Great job, no security vulnerabilities found in this Pull Request

@ShooterIT ShooterIT linked an issue Jul 11, 2025 that may be closed by this pull request
@ShooterIT ShooterIT changed the title Fix memleak issue in redis-cli #14184 Fix memleak issues in redis-cli Jul 11, 2025
@ShooterIT ShooterIT merged commit ebf19e4 into redis:unstable Jul 11, 2025
19 checks passed
@ShooterIT

Copy link
Copy Markdown
Member

merged, thank you @sfu2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Possible memory leak in cliLegacyIntegrateHelp at redis-cli.c [BUG] Possible memory leak in cliInitHelp at redis-cli.c

4 participants