Skip to content

Fix potential infinite loop of RANDOMKEY during client pause #13893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
youngmore1024 wants to merge 1 commit into
base: 6.2
Choose a base branch
from
Open

Fix potential infinite loop of RANDOMKEY during client pause #13893

youngmore1024 wants to merge 1 commit into from

Conversation

@youngmore1024
Copy link
Contributor

@youngmore1024 youngmore1024 commented Mar 26, 2025 •
edited by sundb
Loading

Fixed #13862.
This fix is just for 6.2.

@youngmore1024
Fix potential infinite loop of RANDOMKEY during client pause
e9cc9ea 
Signed-off-by: youngmore1024 <youngmore1024@outlook.com>
sundb
sundb approved these changes Mar 27, 2025
View reviewed changes
Copy link
Collaborator

@sundb sundb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@sundb sundb requested a review from oranagra March 27, 2025 06:05
@sundb
Copy link
Collaborator

sundb commented Mar 27, 2025

@oranagra this bug was introduced from 6.2, should we backport this to 6.2 with a special PR?

@sundb sundb added the release-notes indication that this issue needs to be mentioned in the release notes label Mar 27, 2025
@oranagra
Copy link
Member

oranagra commented Mar 27, 2025

  1. indeed we're still supporting 6.2. so the question is if this is a critical bug fix, and is it safe enough to justify backporting to stable releases.
  2. i see we marked the other PR for backport to 7.2 and 7.4, why not do the same for 6.2?

@sundb
Copy link
Collaborator

sundb commented Mar 27, 2025

@oranagra because this check code for 6.2 and 7.2 was changed:
6.2: server.client_pause_type == CLIENT_PAUSE_WRITE
7.2: isPausedActions(PAUSE_ACTION_EXPIRE)

@oranagra
Copy link
Member

oranagra commented Mar 30, 2025

ok, from my perspective this seems simple enough so that we can handle it by cherry pick, we'll get a conflict and resolve it.
but i don't mind. whatever is comfortable to you...

@sundb sundb mentioned this pull request Jul 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sundb sundb sundb approved these changes

@oranagra oranagra Awaiting requested review from oranagra

Assignees

No one assigned

Labels

release-notes indication that this issue needs to be mentioned in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@youngmore1024 @sundb @oranagra