Add active_rehashing_cpu_milliseconds to INFO STATS#13110
Add active_rehashing_cpu_milliseconds to INFO STATS#13110enjoy-binbin wants to merge 1 commit intoredis:unstablefrom
Conversation
This field is similar to expire_cycle_cpu_milliseconds, it represents the CPU time we use in activerehashing, to see how much time we generally spend in activerehashing.
oranagra
left a comment
There was a problem hiding this comment.
LGTM. @redis/core-team please approve.
|
we discussed this in a core-team meeting and we weren't sure if we want it, and how useful it is. we didn't want to spam the info fields (although this is a mirror of expire_cycle_cpu_milliseconds) |
|
another point i want to mention is that currently we will spend a fixed 1000us in each serverCron to do activerehash. The text describe it in redis.conf is:
however, this is when hz = 10. Sometimes users set hz randomly, causing the load to become higher. although we now have some new indicators, it doesn’t seem to be clear (we did not mention it in the redis.conf, it look like we should). or i previously suggested changing 1000us to something like active expire or defrag based on hz calculation.
|
|
|
This field is similar to expire_cycle_cpu_milliseconds, it represents
the CPU time we use in activerehashing, to see how much time we generally
spend in activerehashing.