Skip to content

Fix timing issue in CLUSTER SLAVE / REPLICAS consistent test #12774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oranagra merged 1 commit into from
Nov 19, 2023
Merged

Fix timing issue in CLUSTER SLAVE / REPLICAS consistent test #12774

oranagra merged 1 commit into from
Nov 19, 2023

Conversation

@enjoy-binbin
Copy link
Contributor

@enjoy-binbin enjoy-binbin commented Nov 17, 2023

CI reports that this test failed, the reason is because during
the command processing, the node processed PING/PONG, resulting
in ping_sent or pong_received mismatch.

Change to use MULTI to avoid timing issue. The test was introduced
in #12224.

@enjoy-binbin
Fix timing issue in CLUSTER SLAVE / REPLICAS consistent test
6abcb1e 
CI reports that this test failed, the reason is because during
the command processing, the node processed PING/PONG, resulting
in ping_sent or pong_received mismatch.

Change to use MULTI to avoid timing issue. The test was introduced
in redis#12224.
@enjoy-binbin
Copy link
Contributor Author

enjoy-binbin commented Nov 17, 2023 •
edited
Loading

https://github.com/redis/redis/actions/runs/6897990549/job/18767196633#step:9:281

00:39:10> CLUSTER SLAVES and CLUSTER REPLICAS output is consistent: FAILED: Expected 
'{fbb483a874a80fd840d2e209b37165832b67ab31 127.0.0.1:30005@40005 slave 54f47cc55ed8096cc74264b3c843a8dc842ad06e 0 1700181549556 1 connected}
{3c64e94cf4c42229ca9003c0ba3f21fcdbc67942 127.0.0.1:30010@40010 slave 54f47cc55ed8096cc74264b3c843a8dc842ad06e 0 1700181549000 1 connected}'
to be equal to 
'{fbb483a874a80fd840d2e209b37165832b67ab31 127.0.0.1:30005@40005 slave 54f47cc55ed8096cc74264b3c843a8dc842ad06e 0 1700181550000 1 connected} 
{3c64e94cf4c42229ca9003c0ba3f21fcdbc67942 127.0.0.1:30010@40010 slave 54f47cc55ed8096cc74264b3c843a8dc842ad06e 0 1700181549000 1 connected}'
 (context: type eval line 6 cmd {assert_equal $res $res2} proc ::test)
(Jumping to next unit after error)

@oranagra oranagra merged commit 3d9c427 into redis:unstable Nov 19, 2023
@enjoy-binbin enjoy-binbin deleted the fix_timing_issue_ci branch November 19, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oranagra oranagra oranagra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Redis Triage
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@enjoy-binbin @oranagra