Move clusterBeforeSleep before blockedBeforeSleep #12343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new blockedBeforeSleep was added in redis#12337, it breaks the order in 2ecb5ed. This may be related to redis#2288, quoted from comment in redis#2288: ``` Moreover the clusterBeforeSleep() call was misplaced at the end of the chain of the beforeSleep() call in redis.c. It should be at the top, before processing un blocking clients. This is exactly the reason in the specific instance of the bug as reported, why the state was not updated in time before clients served. ```
enjoy-binbin
commented
Jun 25, 2023
Contributor
Author
|
another question: should cron_start_time_before_aof be considered? |
Member
i don't think clusterBeforeSleep is expected to consume a lot of time, i don't mind if we don't count it. |
Contributor
Author
|
i can't reproduce the problem and write a test case now, please feel free to merge it first. |
Co-authored-by: Binbin <binloveplay1314@qq.com>
oranagra
approved these changes
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new blockedBeforeSleep was added in #12337, it breaks the order in 2ecb5ed.
This may be related to #2288, quoted from comment in #2288: