Skip to content

Conversation

@madolson
Copy link
Contributor

@madolson madolson commented Jun 20, 2023

Resolves issue with nodename test as seen in https://github.com/redis/redis/actions/runs/5313162983/jobs/9618669303?pr=12159.

To determine when everything was stable, we couldn't just query the nodename since they aren't API visible by design. Instead, we were using a proxy piece of information which was bumping the epoch and waiting for everyone to observe that. This works for making source Node 0 and Node 1 had pinged, and Node 0 and Node 2 had pinged, but did not guarantee that Node 1 and Node 2 had pinged. Although unlikely, this can cause this failure message. To fix it I hijacked hostnames and used its validation that it has been propagated, since we know that it is stable.

I also noticed while stress testing this sometimes the test took almost 4.5 seconds to finish, which is really close to the current 5 second limit of the log check, so I bumped that up as well just to make it a bit more consistent.

@madolson madolson requested review from hwware and oranagra June 20, 2023 00:12
@madolson madolson merged commit 73cf024 into redis:unstable Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants