Skip to content

Add missing master_reboot flag in sentinel instance info#11888

Merged
oranagra merged 1 commit into
redis:unstablefrom
enjoy-binbin:add_missing_flag_in_info
Mar 21, 2023
Merged

Add missing master_reboot flag in sentinel instance info#11888
oranagra merged 1 commit into
redis:unstablefrom
enjoy-binbin:add_missing_flag_in_info

Conversation

@enjoy-binbin

Copy link
Copy Markdown
Contributor

SRI_MASTER_REBOOT flag was added in #9438

@enjoy-binbin

enjoy-binbin commented Mar 8, 2023

Copy link
Copy Markdown
Contributor Author

I found this while trying to fix a sentinel CI test.
@hwware FYI

btw, would it be more appropriate to change to SRI_MASTER_REBOOTING?

@hwware

hwware commented Mar 8, 2023

Copy link
Copy Markdown
Contributor

I found this while trying to fix a sentinel CI test. @hwware FYI

btw, would it be more appropriate to change to SRI_MASTER_REBOOTING?

I do not think change to SRI_MASTER_REBOOTING is a good idea, because reboot do not take long time, the loading after reboot takes long time

@enjoy-binbin

Copy link
Copy Markdown
Contributor Author

I do not think change to SRI_MASTER_REBOOTING is a good idea, because reboot do not take long time, the loading after reboot takes long time

great, got it

@enjoy-binbin enjoy-binbin requested a review from yossigo March 11, 2023 08:29
@enjoy-binbin enjoy-binbin requested a review from oranagra March 19, 2023 09:57
@oranagra

Copy link
Copy Markdown
Member

i don't know anything about sentinel, so maybe i should leave this for Yossi.
is this flag meant to be used by users or just tests?
should it be mentioned in the release notes?
you said you noticed it's missing when working on a failed test, did you need it in order to fix the test? or just for debugging?

@enjoy-binbin

Copy link
Copy Markdown
Contributor Author

is this flag meant to be used by users or just tests?

I guess it was meant to be used by users

should it be mentioned in the release notes?

look like we don't.
#8682

you said you noticed it's missing when working on a failed test, did you need it in order to fix the test? or just for debugging?

currently i don't need it. Just look the code and find it

@hwware

hwware commented Mar 21, 2023

Copy link
Copy Markdown
Contributor

i don't know anything about sentinel, so maybe i should leave this for Yossi. is this flag meant to be used by users or just tests? should it be mentioned in the release notes? you said you noticed it's missing when working on a failed test, did you need it in order to fix the test? or just for debugging?

SRI_MASTER_REBOOT flag is only for the user (aka our codes), we do not need to add it in the release note.

@oranagra oranagra merged commit 1cb4b1a into redis:unstable Mar 21, 2023
@enjoy-binbin enjoy-binbin deleted the add_missing_flag_in_info branch March 21, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants