Skip to content

Conversation

@pixclk
Copy link

@pixclk pixclk commented Jul 18, 2022

Hello, I saw that _dictNextExp in dict needs to be optimized, so I added it.

Performance optimization under GCC and clang.
@oranagra
Copy link
Member

This has been suggested (and rejected) many times, AFAIK one of the first was this one: #2382
(a portable approach of 5 conditional shifts instead of that ugly loop)

@pixclk
Copy link
Author

pixclk commented Jul 18, 2022

But I have tested before, which will improve the performance 10 times on X86.

@oranagra
Copy link
Member

improve performance of what?
performance of this function when tested in a loop? or some actual workload of redis?
the reason it was rejected by the previous maintainer was that the performance of this function isn't important for redis since is very rarely used.
the other argument against is was that it make the code less readable. this is something i didn't agree with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:to-be-closed requesting the core team to close the issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants