Enable redis-benchmark to use RESP3 protocol mode#10335
Merged
Conversation
oranagra
reviewed
Feb 23, 2022
oranagra
approved these changes
Feb 23, 2022
Member
|
@yossigo please ack (i suppose despite being an interface change, it's not a major decision) |
Member
|
p.s. should me mention this in the release notes? |
yossigo
approved these changes
Feb 27, 2022
Collaborator
|
@oranagra I agree it's not a major decision, but should be in the release notes. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
-3option to cause redis-benchmark to send aHELLO 3to it can benchmark the effects of RESP3 on the server.