Skip to content

.gitignore files are too aggressive in 2.6.12 #1058

@rrueth

Description

@rrueth

When using thirdparty tools in our system, my company will commit the third party source code so that the tool can built and distributed easily across various systems. We also use git for version control. When committing the redis 2.6.12 source to our repository, I noticed that a few of the files required for building redis and jemalloc were being ignored in the main .gitignore and deps/jemalloc/.gitignore.

Specifically, the main .gitignore was ignoring:

src/redis-benchmark.c
src/redis-check-aof.c
src/redis-check-dump.c
src/redis-cli.c
src/release.h
tests/assets/encodings.rdb
tests/assets/hash-zipmap.rdb
tests/integration/redis-cli.tcl
utils/redis-copy.rb
utils/redis-sha1.rb

I believe that the offending lines in .gitignore are:
redis-*
release.h
*.rdb

Second, in deps/jemalloc/.gitignore, the following files were being ignored:
deps/jemalloc/VERSION
deps/jemalloc/configure
deps/jemalloc/doc/jemalloc.3
deps/jemalloc/doc/jemalloc.html
deps/jemalloc/test/jemalloc_test.h.in

I believe that the offending lines in deps/jemalloc/.gitignore are:
/configure
doc/jemalloc.html
/doc/jemalloc.3
/test/jemalloc_test.h
/VERSION

I understand that this practice of committing the source code of third-party tools may not be the norm, but it would be nice to fix the .gitignores tonot ignore files that are already committed/part of the tarball (as .gitignore has no effect on files that are already being tracked).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions