fix: keep registry identity in sync after _setIdentity

PavelPashov · PavelPashov · commit 6b0433169d9d · 2026-03-25T13:58:59.000+02:00
diff --git a/packages/client/lib/client/identity.ts b/packages/client/lib/client/identity.ts
@@ -29,8 +29,8 @@ export enum ClientRole {
  */
 export interface ClientIdentity {
   readonly id: string;
-  readonly role: ClientRole;
-  readonly parentId?: string;
+  role: ClientRole;
+  parentId?: string;
 }
 
 /**
diff --git a/packages/client/lib/client/index.ts b/packages/client/lib/client/index.ts
@@ -481,11 +481,11 @@ export default class RedisClient<
    * Sets the client identity. Used by pool/cluster/sentinel when creating child clients.
    */
   _setIdentity(role: ClientRole, parentId?: string): void {
-    this._self.#clientIdentity = {
-      ...this._self.#clientIdentity,
-      role,
-      parentId
-    };
+    this._self.#clientIdentity.role = role;
+
+    if (parentId) {
+      this._self.#clientIdentity.parentId = parentId;
+    }
   }
 
   /**
diff --git a/packages/client/lib/opentelemetry/client-registry.spec.ts b/packages/client/lib/opentelemetry/client-registry.spec.ts
@@ -126,7 +126,7 @@ describe("ClientRegistry Unit Tests", () => {
 
   it("should handle unix socket clients", () => {
     ClientRegistry.init();
-    
+
     createClient({
       socket: {
         path: "/tmp/redis.sock",
@@ -148,6 +148,25 @@ describe("ClientRegistry Unit Tests", () => {
     assert.strictEqual(attributes.db, 0);
     assert.strictEqual(attributes.clientId, handle.identity.id);
   });
+
+  it("should reflect identity updates after _setIdentity", () => {
+    ClientRegistry.init();
+
+    const client = createClient();
+    const originalId = client._clientId;
+
+    client._setIdentity(ClientRole.POOL_MEMBER, "pool-1");
+
+    const handle = ClientRegistry.instance.getById(originalId);
+    assert.ok(handle);
+    assert.strictEqual(handle.identity.id, originalId);
+    assert.strictEqual(handle.identity.role, ClientRole.POOL_MEMBER);
+    assert.strictEqual(handle.identity.parentId, "pool-1");
+
+    const attributes = handle.getAttributes();
+    assert.strictEqual(attributes.clientId, originalId);
+    assert.strictEqual(attributes.parentId, "pool-1");
+  });
 });
 
 describe("ClientRegistry E2E", function () {
