Merged
Conversation
Cherry-picked and re-applied clang-format configuration, CI workflow, Makefile targets, and DEVELOPMENT.md docs from master. Source files reformatted against the 2.2.x branch codebase.
* Concurrent ubuntu test jobs for faster CI * Prevent duplicate workflow runs on push+PR by filtering branches * Fixed coverage workflow * Concurrent ASAN, TSAN, and UBSAN test jobs using matrix strategy
* Fix rate-limit induced hanging at test completion * include a null check for conns in all_connections_idle * Remove crufty ctx reference * Extend CI with higher shard count scenario. * Extra logging on 99 shards scenario * Verbose was already defined on CI. Using 49 shards to expedite CI * Using RLTEST_DEBUG to avoid overriding old behaviour * Shard count 99 in rate-limiting test --------- Co-authored-by: fcostaoliveira <filipe@redis.com>
Add documentation to help AI assistants work effectively with the memtier_benchmark codebase, following the https://agents.md/ conventions. AGENTS.md includes: - Project overview and repository structure - Build system and commands (autotools) - Code style (clang-format) - Testing with RLTest (standalone, cluster, TLS, sanitizers) - Key technical details - Common development tasks - Debugging guide (GDB, crash handler, core dumps, sanitizers) - License header requirements CLAUDE.md points to AGENTS.md for shared guidelines. References: - https://agents.md/ - Standard for AI agent documentation - https://docs.anthropic.com/en/docs/agents - Anthropic agent guidelines
Collaborator
Author
|
cursor review |
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
Add branch pattern '[0-9]+.[0-9]+' to push/pull_request triggers for ci, code-style, asan, tsan, and ubsan workflows so CI runs on PRs targeting release branches like 2.2.
cb55c89 to
18d002c
Compare
The rate-limiting timer was only created on the first connection (when get_reqs_processed() == 0). After a reconnect triggered by --reconnect-interval, disconnect() properly freed the timer, but handle_event() never recreated it because requests had already been processed. This left m_request_per_cur_interval permanently at 0, causing fill_pipeline() to return immediately on every call. Move timer creation outside the first-connection guard so it is recreated on every successful connect/reconnect when m_event_timer is NULL. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
cursor review |
paulorsousa
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picked PRs:
CXXFLAGS#342 - configure: Respect user-supplied CXXFLAGSTest plan
Note
Medium Risk
Moderate risk due to changes in client connection lifecycle/idle detection and significant CI workflow restructuring; most other edits are formatting/doc/version bumps with low runtime impact.
Overview
Prepares the
2.2.2release by bumpingconfigure.acversion and ensuring user-suppliedCXXFLAGSare respected.Adds repo-wide
clang-formatsupport (.clang-format,make format/format-check) and a newCode StyleGitHub Action that enforces formatting in PRs; includes large-scale formatting-only reflows across multiple C/C++ files and vendored headers.Refactors GitHub Actions to run on release branches only, splits sanitizer workflows (ASAN/TSAN/UBSAN) and Ubuntu CI into separate build and matrix test jobs with uploaded artifacts, and updates org/repo references from
RedisLabs/redislabstoredis(including Docker workflow gating).Fixes a test-completion hang scenario by extending the connection manager interface with
all_connections_idle()and addingdisconnect_all()/idle detection inclient, enabling cleaner shutdown when multiple connections still have pending responses.Written by Cursor Bugbot for commit 9180243. This will update automatically on new commits. Configure here.