Issue #285, Fix rate-limiting with cluster-mode#286
Merged
YaacovHazan merged 1 commit intoredis:masterfrom Jan 5, 2025
Merged
Conversation
When a connection disconnected, the timer event was not free, and cause the test to keep running forever. One of these cases is when we are starting the benchmark in cluster-mode and using the replica's ip/port.
filipecosta90
approved these changes
Jan 5, 2025
Contributor
|
Hi, we believe that this commit may have severely regressed cluster mode performance in memtier_benchmark. After upgrading from 2.1.1 to 2.1.3, our performance tests are indicating a nearly 50% drop in throughput and 10x higher P99.9. This PR appears to be associated with the only commit in 2.1.3 that meaningfully changes the benchmark's core logic. |
Collaborator
Contributor
|
Confirming that #295 applied on top of 2.1.3 indeed fixes the perf regression we are observing. Thanks! (Apologies for jumping to conclusions on the root cause; we didn't have time yesterday to dive deeper after noticing the original issue.) |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a connection disconnected, the timer event was not free, and cause the test to keep running forever.
One of these cases is when we are starting the benchmark in cluster-mode and using the replica's ip/port.