Add .gitattributes file for better behavior on Windows-based systems#266
Merged
filipecosta90 merged 1 commit intoredis:masterfrom Sep 25, 2024
Merged
Add .gitattributes file for better behavior on Windows-based systems#266filipecosta90 merged 1 commit intoredis:masterfrom
filipecosta90 merged 1 commit intoredis:masterfrom
Conversation
...to ensure text files are checked out on all dev systems as LF, which is **required** for this project to build correctly.
Contributor
Author
|
@filipecosta90 this should be a fairly low-risk change. The only net change that will be seen is on Windows systems upon checkout of the repo - text files will default to LF line endings rather than CRLF, which is required to build successfully. |
filipecosta90
approved these changes
Sep 25, 2024
Collaborator
merging @DrEsteban :) Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding this file will ensure text files are checked out on all dev systems as LF, which is required for this project to build correctly.
As mentioned in #163, if you check out this project on a Windows system and try to
docker build, you'll get:I determined this is because text-based files that are expected to be LF at build time are being automatically checked out as CRLF on Windows machines. When those CRLF files are copied over to a Linux-based Docker context at build time, they cause the build to blow up. After renormalizing all text files as LF, the build succeeds as expected.
This change will ensure all contributors, no matter the dev OS, will be able to work with this repository as intended immediately upon checkout.