Skip to content

Fixed build for tls v1.3 on openssl v1.0.2. Added CI check#253

Merged
filipecosta90 merged 4 commits intomasterfrom
openssl.1.0
Apr 8, 2024
Merged

Fixed build for tls v1.3 on openssl v1.0.2. Added CI check#253
filipecosta90 merged 4 commits intomasterfrom
openssl.1.0

Conversation

@filipecosta90
Copy link
Collaborator

@filipecosta90 filipecosta90 commented Apr 7, 2024

This PR:

Reproduced via:

brew install rbenv/tap/openssl@1.0
autoreconf -ivf
PKG_CONFIG_PATH="/opt/homebrew/opt/openssl@1.0/lib/pkgconfig" ./configure
make

error:

(base) fco@fcos-Air memtier_benchmark % make
make  all-am
make[1]: Entering directory '/Users/fco/redislabs/memtier_benchmark'
  CXX      memtier_benchmark-memtier_benchmark.o
memtier_benchmark.cpp:328:16: warning: variable 'ignore' set but not used [-Wunused-but-set-variable]
        size_t ignore = fread(&R, sizeof(R), 1, f);
               ^
memtier_benchmark.cpp:1396:50: error: use of undeclared identifier 'SSL_OP_NO_TLSv1_3'
            SSL_CTX_set_options(cfg.openssl_ctx, SSL_OP_NO_TLSv1_3);
                                                 ^
1 warning and 1 error generated.
make[1]: *** [Makefile:751: memtier_benchmark-memtier_benchmark.o] Error 1
make[1]: Leaving directory '/Users/fco/redislabs/memtier_benchmark'
make: *** [Makefile:492: all] Error 2

@filipecosta90 filipecosta90 merged commit b2a4041 into master Apr 8, 2024
@filipecosta90 filipecosta90 deleted the openssl.1.0 branch April 8, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error reported when executing command 'make'

2 participants