Fixed deprecated and casting build errors caught on recent compilers#248
Merged
filipecosta90 merged 4 commits intomasterfrom Jan 23, 2024
Merged
Fixed deprecated and casting build errors caught on recent compilers#248filipecosta90 merged 4 commits intomasterfrom
filipecosta90 merged 4 commits intomasterfrom
Conversation
Collaborator
filipecosta90
commented
Jan 19, 2024
- Fixes Error when building on MacOS arm64-apple-darwin21.6.0 #247
- I've set an old standard to make this work even for old compiler versions. Agree @YaacovHazan and @yossigo ?
…build in case of new standard usage
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #248 +/- ##
=======================================
Coverage 64.53% 64.53%
=======================================
Files 21 21
Lines 4368 4368
=======================================
Hits 2819 2819
Misses 1549 1549 ☔ View full report in Codecov by Sentry. |
Contributor
|
@filipecosta90 Did you consider fixing the issues themselves? I think it should be fairly simple and still backward compatible, so overall preferred over changing compiler flags. |
Collaborator
Author
Indeed. Addressed in the latest commit @yossigo |
yossigo
previously approved these changes
Jan 23, 2024
Co-authored-by: Yossi Gottlieb <yossigo@gmail.com>
yossigo
approved these changes
Jan 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.