Issue #204, Disable READ/WRITE events if no requests sent#222
Merged
YaacovHazan merged 1 commit intoredis:masterfrom May 17, 2023
Merged
Issue #204, Disable READ/WRITE events if no requests sent#222YaacovHazan merged 1 commit intoredis:masterfrom
YaacovHazan merged 1 commit intoredis:masterfrom
Conversation
In cluster mode, where there are few requests with many shards, some of the shards might not send any requests. Currently, the memtier-benchmark is hang, because the connections to these shards are not disabling their read/write events
yossigo
approved these changes
May 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cluster mode, where there are few requests with many shards, some of the shards might not send any requests.
Currently, the memtier-benchmark is hang, because the connections to these shards are not disabling their read/write events