Include keyspace range checks on flow tests#208
Merged
filipecosta90 merged 1 commit intoredis:masterfrom Feb 14, 2023
Merged
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #208 +/- ##
==========================================
+ Coverage 55.90% 56.97% +1.07%
==========================================
Files 21 21
Lines 4270 4270
==========================================
+ Hits 2387 2433 +46
+ Misses 1883 1837 -46
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ushachar
reviewed
Feb 13, 2023
31cb241 to
61f78b8
Compare
YaacovHazan
approved these changes
Feb 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Up until now we didn't really checked the keyspace range after write tests. This PR introduces it.
I noticed that due to the PR #206 having a but and precisely increasing the keyspace range.