Fixed memory usage increasing over time due to per second histogram usage#188
Merged
filipecosta90 merged 2 commits intomasterfrom Aug 2, 2022
Merged
Fixed memory usage increasing over time due to per second histogram usage#188filipecosta90 merged 2 commits intomasterfrom
filipecosta90 merged 2 commits intomasterfrom
Conversation
Collaborator
Author
|
As discussed with @yaacovhazan-Redislabs sharing the throughput over time for both master and this PR to confirm there is no change/no affected logic due to the changes contained in it.
|
YaacovHazan
approved these changes
Aug 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #157 .
Instead of keeping the raw histograms per second, we keep the computed percentiles that we need to store at the end of the benchmark.
Using @weisiw script to check the memory we can confirm that the issue is gone
