fix issue #133, error when using --data-offset#134
Merged
yaacovhazan-Redislabs merged 1 commit intoredis:masterfrom Jul 16, 2020
Merged
fix issue #133, error when using --data-offset#134yaacovhazan-Redislabs merged 1 commit intoredis:masterfrom
yaacovhazan-Redislabs merged 1 commit intoredis:masterfrom
Conversation
the issue relates to wrong parsing of response with zero size ($0\r\n\r\n), that doesn't handle correctly the last CRLF.
fe60ab4 to
1c08406
Compare
yossigo
approved these changes
Jul 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the issue relates to wrong parsing of response
with zero size ($0\r\n\r\n), that doesn't handle
correctly the last CRLF.