Skip to content

Add CLUSTER SHARDS command support (#2984)#3598

Merged
sazzad16 merged 7 commits into
redis:masterfrom
wormogig:command-cluster-shards
Nov 14, 2023
Merged

Add CLUSTER SHARDS command support (#2984)#3598
sazzad16 merged 7 commits into
redis:masterfrom
wormogig:command-cluster-shards

Conversation

@wormogig

Copy link
Copy Markdown
Contributor

Command CLUSTER SHARDS added to ClusterCommands and command CLUSTER SLOTS marked as depricated.

Comment thread src/main/java/redis/clients/jedis/Jedis.java Outdated

@sazzad16 sazzad16 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks promising!

Comment thread src/main/java/redis/clients/jedis/resps/ClusterShardInfo.java Outdated
Comment thread src/main/java/redis/clients/jedis/resps/ClusterShardNodeInfo.java Outdated
Comment thread src/main/java/redis/clients/jedis/resps/ClusterShardNodeInfo.java Outdated
Comment thread src/main/java/redis/clients/jedis/resps/ClusterShardNodeInfo.java Outdated
Comment thread src/main/java/redis/clients/jedis/resps/ClusterShardNodeInfo.java Outdated
@sazzad16

sazzad16 commented Nov 7, 2023

Copy link
Copy Markdown
Contributor

@wormogig Please address the remaining 2 change requests and keep the others as is.

Comment thread src/main/java/redis/clients/jedis/BuilderFactory.java Outdated
Comment thread src/main/java/redis/clients/jedis/BuilderFactory.java Outdated
Comment thread src/main/java/redis/clients/jedis/BuilderFactory.java Outdated
Comment thread src/main/java/redis/clients/jedis/BuilderFactory.java Outdated
@sazzad16 sazzad16 added this to the 5.1.0 milestone Nov 8, 2023
@codecov-commenter

codecov-commenter commented Nov 9, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (d2f6712) 71.52% compared to head (f949de7) 71.60%.
Report is 7 commits behind head on master.

❗ Current head f949de7 differs from pull request most recent head 7cb5439. Consider uploading reports for the commit 7cb5439 to get more accurate results

Files Patch % Lines
...ava/redis/clients/jedis/JedisClusterInfoCache.java 76.74% 4 Missing and 6 partials ⚠️
.../main/java/redis/clients/jedis/BuilderFactory.java 84.31% 5 Missing and 3 partials ⚠️
...main/java/redis/clients/jedis/ClusterPipeline.java 0.00% 4 Missing ⚠️
...edis/clients/jedis/resps/ClusterShardNodeInfo.java 91.30% 2 Missing ⚠️
...ain/java/redis/clients/jedis/CommandArguments.java 90.90% 0 Missing and 1 partial ⚠️
...va/redis/clients/jedis/resps/ClusterShardInfo.java 87.50% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3598      +/-   ##
============================================
+ Coverage     71.52%   71.60%   +0.08%     
- Complexity     4851     4883      +32     
============================================
  Files           288      290       +2     
  Lines         15461    15610     +149     
  Branches       1095     1115      +20     
============================================
+ Hits          11058    11178     +120     
- Misses         3927     3946      +19     
- Partials        476      486      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread src/main/java/redis/clients/jedis/resps/ClusterShardNodeInfo.java

@yangbodong22011 yangbodong22011 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sazzad16 sazzad16 linked an issue Nov 14, 2023 that may be closed by this pull request
@sazzad16 sazzad16 changed the title Add CLUSTER SHARDS command (#2984) Add CLUSTER SHARDS command support (#2984) Nov 14, 2023
@sazzad16 sazzad16 merged commit 452ea52 into redis:master Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CLUSTER SHARDS command

4 participants