Pipeline with failover to multi cluster#3594
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3594 +/- ##
============================================
- Coverage 71.60% 71.30% -0.31%
+ Complexity 4883 4872 -11
============================================
Files 290 291 +1
Lines 15610 15582 -28
Branches 1115 1113 -2
============================================
- Hits 11178 11111 -67
- Misses 3946 3988 +42
+ Partials 486 483 -3 ☔ View full report in Codecov by Sentry. |
| return new Pipeline(provider.getConnection(), true); | ||
| } | ||
|
|
||
| public Transaction multi() { |
There was a problem hiding this comment.
@sazzad16 See my comment in #3568 (comment).
This is also a problem for multi(), subscribe(), and any methods that use JedisCommandIterationBase. Shouldn't we fix these as well?
There was a problem hiding this comment.
Current plan: Those will be in a different issue, and estimated there.
There was a problem hiding this comment.
#3602 contains multi and supersedes this subscribe
|
We need to ensure that we've tested these changes. Would you like assistance with that @sazzad16 ? |
@banker I haven't found tests from our original failover implementation to imitate here for pipeline implementation. The only closest thing I can see is |
Resolves #3568