fix(hello): do not send maintnotifications handshake when hello fails#3788
Merged
Conversation
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
elena-kolevska
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes connection initialization behavior around protocol negotiation and maintenance-notification setup; could affect clients that request RESP3 but connect to servers/proxies without
HELLOsupport.Overview
Prevents
initConnfrom attempting theCLIENT MAINT_NOTIFICATIONShandshake whenHELLOfails and the connection effectively falls back to RESP2, even ifOptions.Protocolrequested RESP3.If maintnotifications were explicitly enabled (
ModeEnabled) withProtocol: 3,initConnnow fails fast with a clear RESP3/HELLO-related error; for auto modes it silently disables maintnotifications (updatesMaintNotificationsConfig.ModetoModeDisabledand tears down related upgrades) and continues.Adds a mock RESP2 server and new regression tests to assert no
CLIENT MAINT_NOTIFICATIONScommand is sent onHELLOfallback, and to validate the differingModeEnabledvsModeAutooutcomes.Reviewed by Cursor Bugbot for commit b778286. Bugbot is set up for automated code reviews on this repo. Configure here.