fix: make dial tcp error redirectable (#3786)#3787
Merged
ndyakov merged 2 commits intoApr 23, 2026
Conversation
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
57ff717 to
612d7a7
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 612d7a7. Configure here.
1567a81 to
b10003a
Compare
e13fd6b to
0435cdd
Compare
ndyakov
approved these changes
Apr 23, 2026
ndyakov
left a comment
Member
There was a problem hiding this comment.
Thank you @vladisa88, looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3786
The
ShouldRetry()method now checks the timeout error for compliance with its dial tcp timeout error. If there is an error, the function returns true, since the request should be repeated. A dial error means the TCP connection was never established and the command was never sent to the server, so retry is always safeNote
Low Risk
Low risk: small, targeted change to retry classification for network dial timeout errors, with added unit coverage. Potential impact is limited to slightly increasing retries on connection-establishment failures.
Overview
ShouldRetrynow treats timeout errors that are specificallynet.OpErrorwithOp == "dial"as always safe to retry, since no command was sent to Redis.Tests were updated to cover
dialvs non-dialnet.OpErrorcases.Reviewed by Cursor Bugbot for commit e13fd6b. Bugbot is set up for automated code reviews on this repo. Configure here.