fix: suppress pool Close() errors for stale connections#3778
Merged
Conversation
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 238ec1f. Configure here.
ndyakov
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3775
pool.Close()now checksisHealthyConnbefore propagating connection close errors, aligning its behavior with the existing error suppression inGet()where stale connections are silently discarded.This prevents spurious errors (e.g., TLS
closeNotifytimeouts) from being returned when closing a pool whose connections have already been dropped by the server due to idle timeout.Note
Medium Risk
Changes
ConnPool.Close()error propagation semantics by suppressing close errors for connections deemed stale viaisHealthyConn, which could mask some real shutdown-close failures if the health check misclassifies a connection.Overview
ConnPool.Close()now evaluates each connection withisHealthyConnbefore closing it and only propagates the firstClose()error when the connection is still considered healthy; close errors from stale/expired connections are suppressed to matchGet()’s stale-connection handling.Tests add a
failCloseConnhelper to simulate TLS/network close failures and verify thatClose()returns no error for idle-timeout-stale conns, but still returns the close error for healthy ones.Reviewed by Cursor Bugbot for commit 9329719. Bugbot is set up for automated code reviews on this repo. Configure here.