Optimize for Go 1.24: use slices/maps/clear built-ins #3746
Merged
Conversation
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
ndyakov
approved these changes
Mar 23, 2026
- pubsub.go: use clear() to empty maps - search_commands.go: use slices.Clone() and maps.Clone() - command.go: use maps.Clone() in XMessageSliceCmd.Clone() - options.go: use maps.Keys() + slices.Collect() + slices.Sort() - osscluster.go: use slices.SortFunc() instead of custom sort type - proxy_fault_injector_server.go: remove custom min() function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low risk refactor that swaps hand-written clone/sort/map-clear logic for Go stdlib/built-ins; behavior should remain the same but could surface subtle ordering/copy semantics issues in edge cases.
Overview
Modernizes several internals to use Go 1.21+ helpers:
maps.Clone/slices.Clonefor command result cloning (streams/search),clear()for PubSub unsubscribe state, andmaps.Keys+slices.Sort/slices.SortFunc(withcmp.Compare) for deterministic option parsing and cluster slot ordering.Also removes a local
min()helper in the e2e proxy fault injector in favor of the built-inmin.Written by Cursor Bugbot for commit e4de127. This will update automatically on new commits. Configure here.